+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43043/37233

• This PR adds an extra 20KB to repository

A new Pull Request was created by @dinyar (Dinyar Rabady) for master.

It involves the following packages:

• DQM/L1TMonitor (dqm)

@syuvivida, @cmsbuild, @antoniovagnerini, @tjavaid, @nothingface0, @rvenditti can you please review it and eventually sign? Thanks.
@missirol this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@cmsbuild Please test

Hi @dinyar could you create a backport to this PR? In addition, if we want to test this PR in a playback machines online, do you have a suggestions regarding which run to use?
Thanks!!

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22a2f4/35238/summary.html
COMMIT: 6a1aa6a
CMSSW: CMSSW_13_3_X_2023-10-17-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43043/35238/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 1 lines from the logs
• Reco comparison results: 9 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3357400
• DQMHistoTests: Total failures: 9
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3357369
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

@dinyar Do you know whether we would need to modify the unpacking sequence described here: https://github.com/cms-sw/cmssw/blob/master/DQM/Integration/python/clients/l1temulator_dqm_sourceclient-live_cfg.py

DQM directly uses the RawToDigi standard L1 sequence, which when I looked at it doesn't include the ZDC unpacker explicitly. I didn't see a setup file for it under EventFilter either, so I'm not sure if this is genuinely run in the unpacker stage...

@dinyar Do you know whether we would need to modify the unpacking sequence described here: https://github.com/cms-sw/cmssw/blob/master/DQM/Integration/python/clients/l1temulator_dqm_sourceclient-live_cfg.py

DQM directly uses the RawToDigi standard L1 sequence, which when I looked at it doesn't include the ZDC unpacker explicitly. I didn't see a setup file for it under EventFilter either, so I'm not sure if this is genuinely run in the unpacker stage...

I think we don't have to explicitly call the ZDC unpacker, because we use the unpacked uGT inputs which should include the ZDC digis if the modifications made to that unpacker were correct..

@dinyar I did some more research after I wrote that, and I think they wrote themselves into the GT setup so it should be okay.

Hi @dinyar could you create a backport to this PR? In addition, if we want to test this PR in a playback machines online, do you have a suggestions regarding which run to use? Thanks!!

Hi @syuvivida,

Sorry for the long silence. I will make the backport in the next hour hopefully. I don't have a favourite run (any recent run with stable HI beams should be fine), but e.g. 375631 should be a good one.

Cheers,
Dinyar

Hi @syuvivida,

backport created in #43113.

Cheers,
Dinyar

+1

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

+1